Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError: 'specific_test' when running stem's tests #63

Closed
teor2345 opened this issue May 13, 2020 · 2 comments
Closed

KeyError: 'specific_test' when running stem's tests #63

teor2345 opened this issue May 13, 2020 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@atagar @teor2345
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 13, 2020 •
edited

When running stem's tests on commit 99c3043, we see the following error in tor's CI:

Traceback (most recent call last):
File "/home/travis/build/torproject/tor/stem/run_tests.py", line 482, in
main()
File "/home/travis/build/torproject/tor/stem/run_tests.py", line 197, in main
args = test.arguments.Arguments.parse(sys.argv[1:])
File "/home/travis/build/torproject/tor/stem/test/arguments.py", line 109, in parse
args['specific_test'].append(crop_module_name(arg))
KeyError: 'specific_test'
https://travis-ci.org/github/torproject/tor/jobs/686422295#L3615

The previous commit d1174a8 does not appear to have this issue.

Edit: specify the correct working commit.
nmathewson added a commit to nmathewson/tor that referenced this issue May 13, 2020
@nmathewson
Travis: temporarily fix stem version to 1.8.0
43128c2 
This is a workaround for torproject/stem#63
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented May 13, 2020

It's actually d1174a8 that works for me.

nmathewson added a commit to nmathewson/tor that referenced this issue May 14, 2020
@nmathewson
Travis: temporarily fix stem version to d1174a83c2dcb7b8
a895ec6 
This is a workaround for torproject/stem#63
@nmathewson nmathewson mentioned this issue May 14, 2020
Merged
torproject-pusher pushed a commit to torproject/tor that referenced this issue May 14, 2020
@nmathewson
Travis: temporarily fix stem version to d1174a83c2dcb7b8
e63bfca 
This is a workaround for torproject/stem#63
torproject-pusher pushed a commit that referenced this issue May 15, 2020
@atagar
Fix --test and --exclude-test arguments
3a71bd9 
Commit 076f89d rewrote how we parse arguments. This broke our --test and
--exclude-test arguments because there is no longer a default value in the
'args' dictionary...

  % ./run_tests.py --unit --test endpoint
  Traceback (most recent call last):
    File "./run_tests.py", line 482, in <module>
      main()
    File "./run_tests.py", line 197, in main
      args = test.arguments.Arguments.parse(sys.argv[1:])
    File "/home/atagar/Desktop/stem/test/arguments.py", line 109, in parse
      args['specific_test'].append(crop_module_name(arg))
  KeyError: 'specific_test'

Reported by teor on...

  #63
@atagar
Copy link
Contributor

@atagar atagar commented May 15, 2020

Thanks teor! Fixed...

https://gitweb.torproject.org/stem.git/commit/?id=3a71bd9

@atagar atagar closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment