Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/integ/process.py: Detect Tor exiting with nonzero exitcode #54

Merged
merged 1 commit into from Jan 23, 2020
Merged

test/integ/process.py: Detect Tor exiting with nonzero exitcode #54

merged 1 commit into from Jan 23, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nmathewson @atagar @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jan 23, 2020

The take_ownership_via_{pid,controller} tests previously used
"tor_process_poll() == 0" to see whether Tor had existed. This
caused a misleading test failure in the case where Tor exited
because of a signal, or returned a nonzero exit code: the tests
would report that Tor had not exited at all.
@nmathewson
test/integ/process.py: Detect Tor exiting with nonzero exitcode
4afc6de 
The take_ownership_via_{pid,controller} tests previously used
"tor_process_poll() == 0" to see whether Tor had existed.  This
caused a misleading test failure in the case where Tor exited
because of a signal, or returned a nonzero exit code: the tests
would report that Tor had not exited at all.
@nmathewson nmathewson mentioned this pull request Jan 23, 2020
Closed
@torproject-pusher torproject-pusher merged commit 4afc6de into torproject:master Jan 23, 2020
@atagar
Copy link
Contributor

@atagar atagar commented Jan 23, 2020

Wonderful, thanks Nick! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment