Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Add a one-word sentinel value of 0x0 at the end of each buf_t chunk
This helps protect against bugs where any part of a buf_t's memory is passed to a function that expects a NUL-terminated input. It also closes TROVE-2016-10-001 (aka bug 20384).
- Loading branch information
1 parent
12a7298
commit 3cea86e
Showing
2 changed files
with
43 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| o Major features (security fixes): | ||
|
|
||
| - Prevent a class of security bugs caused by treating the contents | ||
| of a buffer chunk as if they were a NUL-terminated string. At | ||
| least one such bug seems to be present in all currently used | ||
| versions of Tor, and would allow an attacker to remotely crash | ||
| most Tor instances, especially those compiled with extra compiler | ||
| hardening. With this defense in place, such bugs can't crash Tor, | ||
| though we should still fix them as they occur. Closes ticket 20384 | ||
| (TROVE-2016-10-001). | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters