Bug30236 sendme rebase #1000

asn-d6 · 2019-05-03T15:31:28Z

No description provided.

This will be our base for incrementally hiding crypt_path_t.

This commit only moves code, and makes one function public.

This commit only moves code.

Create some functions to eventually be able to hide crypt_path_t.crypto.

Everything is moved, but the argument of the function is edited to access ->private->crypto.

Again everything is moved, apart from a free line using ->private.

We are using an opaque pointer so the structure needs to be allocated on the heap. This means we now need a constructor for crypt_path_t. Also modify all places initializing a crypt_path_t to use the constructor.

Now that we are using a constructor we should be more careful that we are always using the constructor to initialize crypt_path_t, so make sure that ->private is initialized.

Some of these functions are now public and cpath-specific so their name should signify the fact they are part of the cpath module: assert_cpath_layer_ok -> cpath_assert_layer_ok assert_cpath_ok -> cpath_assert_ok onion_append_hop -> cpath_append_hop circuit_init_cpath_crypto -> cpath_init_circuit_crypto circuit_free_cpath_node -> cpath_free onion_append_to_cpath -> cpath_extend_linked_list

- Move test-only cpath_get_n_hops() to crypt_path.c. - Move onion_next_hop_in_cpath() and rename to cpath_get_next_non_open_hop(). The latter function was directly accessing cpath->state, and it's a first step at hiding ->state.

This reverts commit ab8b809.

This reverts commit 7497c91.

coveralls · 2019-05-03T15:53:58Z

Pull Request Test Coverage Report for Build 4953

68 of 101 (67.33%) changed or added relevant lines in 8 files are covered.
11 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.009%) to 62.37%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/core/crypto/relay_crypto.c	4	5	80.0%
src/core/or/circuitlist.c	3	5	60.0%
src/feature/rend/rendservice.c	0	2	0.0%
src/core/or/circuitbuild.c	1	6	16.67%
src/core/or/crypt_path.c	55	78	70.51%

Files with Coverage Reduction	New Missed Lines	%
src/core/or/circuitpadding.c	11	91.02%

Totals
Change from base Build 4942:	-0.009%
Covered Lines:	46445
Relevant Lines:	74467

💛 - Coveralls

asn-d6 added 18 commits May 3, 2019

Hiding crypt_path_t: Introduce opaque crypt_path_private_t .

c3a5e6b

This will be our base for incrementally hiding crypt_path_t.

Hiding crypt_path_t: Move assert functions in crypt_path.c.

9584798

This commit only moves code, and makes one function public.

Hiding crypt_path_t: Move init functions to crypt_path.c.

f74a80d

This commit only moves code.

Hiding crypt_path_t: Start with crypt_path.crypto .

0c5176d

Create some functions to eventually be able to hide crypt_path_t.crypto.

Hiding crypt_path_t: Move some more init funcs in crypt_path.c.

5f96b7a

Everything is moved, but the argument of the function is edited to access ->private->crypto.

Hiding crypt_path_t: Move the free func in crypt_path.c.

4bd0c48

Again everything is moved, apart from a free line using ->private.

Hiding crypt_path_t: Fixup broken unittests.

18d61c0

Hiding crypt_path_t: Create a constructor for crypt_path_t.

f563598

We are using an opaque pointer so the structure needs to be allocated on the heap. This means we now need a constructor for crypt_path_t. Also modify all places initializing a crypt_path_t to use the constructor.

Hiding crypt_path_t: Ensure that ->private is initialized.

cd38e41

Now that we are using a constructor we should be more careful that we are always using the constructor to initialize crypt_path_t, so make sure that ->private is initialized.

Hiding crypt_path_t: Trivial changes to satisfy check-local.

593b772

Hiding crypt_path_t: Some TODO notes for future directions.

2e9e3e7

Revert "Hiding crypt_path_t: Create a constructor for crypt_path_t."

4060b76

This reverts commit ab8b809.

Revert "Hiding crypt_path_t: Ensure that ->private is initialized."

2ef0324

This reverts commit 7497c91.

Hiding crypt_path_t: Hiding 'crypto' using a macro.

55d35c0

Hiding crypt_path_t: Change code to use the privatization macro.

ea5f355

Hiding crypt_path_t: Hide 'crypto' usage in sendme.c

7f2cd65

Hiding crypt_path_t: Add changes file.

e9769d6

torproject-pusher merged commit e9769d6 into torproject:master May 8, 2019
2 checks passed

torproject / tor Public

Bug30236 sendme rebase #1000

Bug30236 sendme rebase #1000

asn-d6 commented May 3, 2019

coveralls commented May 3, 2019 •

edited

torproject / tor Public

Bug30236 sendme rebase #1000

Bug30236 sendme rebase #1000

Conversation

asn-d6 commented May 3, 2019

coveralls commented May 3, 2019 • edited

Pull Request Test Coverage Report for Build 4953

💛 - Coveralls

coveralls commented May 3, 2019 •

edited