Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More subsystems #1002

Merged
merged 2 commits into from May 15, 2019
Merged

More subsystems #1002

merged 2 commits into from May 15, 2019

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @dgoulet-tor @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 6, 2019

No description provided.

nmathewson added 2 commits May 6, 2019
@nmathewson
Create a relay subsystem and move the shutdown functions there
b394b5b
@nmathewson
Move "relay" and "router" periodic callbacks out of mainloop.c
3c2648b 
(Some of these callbacks are specific to the OR module, so now it's
time to have an or_sys and or_periodic.)
@coveralls
Copy link

@coveralls coveralls commented May 6, 2019 •
edited

Pull Request Test Coverage Report for Build 4959

  • 37 of 126 (29.37%) changed or added relevant lines in 4 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.001%) to 62.388%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/or_periodic.c 4 11 36.36%
src/feature/relay/relay_periodic.c 15 97 15.46%
Files with Coverage Reduction New Missed Lines %
src/core/mainloop/mainloop.c 1 35.52%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 4949: -0.001%
Covered Lines: 46465
Relevant Lines: 74477
💛 - Coveralls

dgoulet-tor
dgoulet-tor reviewed May 14, 2019
View changes
src/feature/relay/relay_sys.c

static int
subsys_relay_initialize(void)
{
Copy link
Contributor

@dgoulet-tor dgoulet-tor May 14, 2019

Where are all the init functions? I know dns_init() is one of them. Maybe also init_keys() ?

Copy link
Contributor Author

@nmathewson nmathewson May 14, 2019

dns_init and init_keys can't actually go here, since they require configuration. Once we refactor the configuration system to work with our subsystems logic, that's when we'll want to move those.

@torproject-pusher torproject-pusher merged commit 3c2648b into torproject:master May 15, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment