Bug29085 microcommits rebase2 #1024
Closed
Conversation
This commit moves the padding state limit checks and the padding rate limit checks out of the token removal codepath, and causes all three functions to get called from a single circpad_machine_count_nonpadding_sent() function. It does not change functionality.
This commit moves code that updates the state length and padding limit counts out from the callback to its own function, for clarity. It does not change functionality.
Deliver nonpadding events instead of calling token removal functions.
Since RTT estimation is disabled in our default machines, this should not be reached, but it may prove helpful in the future.
…oval explicit. Make this relationship and all the checks be part of its own function. Everything is cleaner that way.
Our other tests tested state lengths against padding packets, and token counts against non-padding packets. This test checks state lengths against non-padding packets (and also padding packets too), and checks token counts against padding packets (and also non-padding packets too). The next three commits are needed to make this test pass (it found 3 bugs). Yay?
We need to check here because otherwise we can try to schedule padding with no tokens left upon the receipt of a padding event when our bins just became empty.
Free circpad machine to pass leaksanitizer in CI.
…e to a github auto-rebase of a PR Because github PRs choose the most recent origin/master at the time of the PR (and for any fixups pushed to a PR later to send to CI), there are tons of conflicts and unexpected practracker issues. This means CI can suddenly fail after fixups to a branch that pass locally. Then CI fails and we have to close and re-open the PR.
Pull Request Test Coverage Report for Build 5017
|
Closed
… in use. Rate limit rtt failure loglines and make them bugs.
Hmm, this is the second time we get this kind of bug, and it seems like really hard to detect except if a test stumbles upon it. How can we improve it? Perhaps we should de-macro this and turn it into a type-safe function with appropriate naming? Also when should we use one and not the other in general? I'm still not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: