Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity in tests #1032

Merged
merged 4 commits into from May 30, 2019
Merged

Coverity in tests #1032

merged 4 commits into from May 30, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 16, 2019

No description provided.

nmathewson added 4 commits May 16, 2019
@nmathewson
rng_test_helpers: add a needless lock/unlock pair to please coverity
1bf451c 
Fix for CID 1444908
@nmathewson
hs tests: explicitly free 'service' variable.
0a9685b 
This should fix about 15 CID issues, where coverity can't tell that
hs_free_all() frees the service we allocated.
@nmathewson
test_channel_listener: free 'chan' explicitly
d5db40a 
This should fix CID 1437442, where coverity can't tell that
channel_free_all() frees the fake channel we allocated.
@nmathewson
changes file for coverity fixes in tests (30150)
6246f45
@coveralls
Copy link

@coveralls coveralls commented May 16, 2019

Pull Request Test Coverage Report for Build 5044

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 62.475%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 2 92.64%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
src/core/or/channel.c 13 81.77%
Totals Coverage Status
Change from base Build 5038: -0.04%
Covered Lines: 46623
Relevant Lines: 74627
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 6246f45 into torproject:master May 30, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment