Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug28634 final #1033

Merged
merged 14 commits into from May 17, 2019
Merged

Bug28634 final #1033

merged 14 commits into from May 17, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mikeperry-tor @coveralls @torproject-pusher @asn-d6
@mikeperry-tor
Copy link
Contributor

@mikeperry-tor mikeperry-tor commented May 16, 2019

No description provided.

asn-d6 and others added 14 commits May 16, 2019
@asn-d6
Behave correctly when state->max_length is zero.
a014e01
@asn-d6
Make register_padding_machine part of the public API.
39c52d1 
We are gonna use this function to register our new machine.
@asn-d6
Generate non-padding circpad events for PADDING_NEGOTIATE(D).
5791bc9 
As part of our machines, we need to know when a PADDING_NEGOATIATE(D) cell gets
sent out, so we add an event for this.
@asn-d6
Introduce circpad free_all() function.
69a277f
@asn-d6
Correctly handle machines out of tokens that have not closed yet.
9b582ed 
Perhaps the machine on the other side is still not done.
@asn-d6
Add client-side onion service circuit hiding machines.
ac895fa
@asn-d6
Add unittests for the new machines.
953dc60
@asn-d6
Improve logging around the circpad module..
42ea3a4 
- Add some more useful logs for future debugging.

- Stop usage of circpad_state_to_string(). It's innacurate.

- Reduce severity and fix up log domain of some logging messages.
@mikeperry-tor
Refactor intro machines, stage 1/2: Move state transition code.
f237fed 
This just moves the state transition directives into the proper client/relay
side functions. It also allows us to remove some dead-code from the client
side (since the client doesn't send padding).
@mikeperry-tor
Refactor intro machines, stage 2/2: Move histogram code.
bbb9742 
The client side had garbage histograms and deadcode here, too. That code has
been removed.

The tests have also been updated to properly test the intro circ by sending
padding from the relay side to the client, and verifying that both shut down
when padding was up. (The tests previously erroneously tested only the client
side of intro circs, which actually were supposed to be doing nothing).
@mikeperry-tor
Refactor rend machines, stage 1/2: Move state transition code.
0cba53c
@mikeperry-tor
Refactor rend machines, stage 2/2: Move histogram code.
857c54c 
Comment clarifications now that the code is seperated. It's the same code, but
its doing this for different reasons on each side.
@mikeperry-tor
Changes file.
1a79bed
@mikeperry-tor
Yes, these functions really do have to be this long.
8427400
@coveralls
Copy link

@coveralls coveralls commented May 16, 2019 •
edited

Pull Request Test Coverage Report for Build 5046

  • 181 of 193 (93.78%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.568%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitpadding.c 41 53 77.36%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 2 92.45%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 5038: 0.06%
Covered Lines: 46792
Relevant Lines: 74786
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 8427400 into torproject:master May 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment