Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug28634 final #1033

merged 14 commits into from May 17, 2019


Copy link

commented May 16, 2019

No description provided.

asn-d6 and others added 14 commits Mar 20, 2019
Make register_padding_machine part of the public API.
We are gonna use this function to register our new machine.
Generate non-padding circpad events for PADDING_NEGOTIATE(D).
As part of our machines, we need to know when a PADDING_NEGOATIATE(D) cell gets
sent out, so we add an event for this.
Correctly handle machines out of tokens that have not closed yet.
Perhaps the machine on the other side is still not done.
Improve logging around the circpad module..
- Add some more useful logs for future debugging.

- Stop usage of circpad_state_to_string(). It's innacurate.

- Reduce severity and fix up log domain of some logging messages.
Refactor intro machines, stage 1/2: Move state transition code.
This just moves the state transition directives into the proper client/relay
side functions. It also allows us to remove some dead-code from the client
side (since the client doesn't send padding).
Refactor intro machines, stage 2/2: Move histogram code.
The client side had garbage histograms and deadcode here, too. That code has
been removed.

The tests have also been updated to properly test the intro circ by sending
padding from the relay side to the client, and verifying that both shut down
when padding was up. (The tests previously erroneously tested only the client
side of intro circs, which actually were supposed to be doing nothing).
Refactor rend machines, stage 2/2: Move histogram code.
Comment clarifications now that the code is seperated. It's the same code, but
its doing this for different reasons on each side.

This comment has been minimized.

Copy link

commented May 16, 2019

Pull Request Test Coverage Report for Build 5046

  • 181 of 193 (93.78%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.568%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitpadding.c 41 53 77.36%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitpadding.c 2 92.45%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 5038: 0.06%
Covered Lines: 46792
Relevant Lines: 74786

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 8427400 into torproject:master May 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.