Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage fixes #1047

Merged
merged 5 commits into from May 28, 2019
Merged

Coverage fixes #1047

merged 5 commits into from May 28, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 24, 2019

No description provided.

nmathewson added 5 commits May 23, 2019
@nmathewson
In coverage builds, avoid basic-block complexity in log_debug
2bb5d81 
Ordinarily we skip calling log_fn(LOG_DEBUG,...) if debug logging is
completely disabled.  However, in coverage builds, this means that
we get spurious complaints about partially covered basic blocks, in
a way that makes our coverage determinism harder to check.
@nmathewson
In coverage builds, use branch-free timeradd() and timersub()
b882810 
The ordinary definitions of timeradd() and timersub() contain a
branch. However, in coverage builds, this means that we get spurious
complaints about partially covered basic blocks, in a way that makes
our coverage determinism harder to check.
@nmathewson
Coverage: do not include test-rebind in coverage builds.
07ccffa 
Because it invokes the Tor mainloop, it does unpredictable things to
test coverage of a lot of code that it doesn't actually test at
all.  (It is more an integration test than anything else.)
@nmathewson
cov-test-determinism: use the same RNG seed as in travis.yml
7893f2c 
We added this facility so that we could get deterministic PRNG
behavior for coverage testing on tests that use a replaced PRNG.
We need to have our coverage determinism tool test for this as well.
@nmathewson
changes file for test coverage
6d9e477
@coveralls
Copy link

@coveralls coveralls commented May 24, 2019

Pull Request Test Coverage Report for Build 5102

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.614%
Files with Coverage Reduction New Missed Lines %
src/core/or/command.c 1 2.21%
src/core/or/sendme.c 1 72.38%
src/core/or/circuitlist.c 1 58.62%
src/lib/compress/compress.c 1 83.78%
src/feature/nodelist/routerlist.c 1 40.74%
src/lib/tls/buffers_tls.c 1 41.54%
src/core/mainloop/mainloop.c 1 35.47%
src/core/or/connection_edge.c 1 26.55%
src/feature/dircache/dircache.c 1 70.67%
src/lib/net/buffers_net.c 1 75.0%
Totals Coverage Status
Change from base Build 5096: 0.04%
Covered Lines: 46883
Relevant Lines: 74876
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 6d9e477 into torproject:master May 28, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment