Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hs: Implement a helper to repurpose a circuit #1053

Open
wants to merge 2 commits into
base: maint-0.3.5
from

Conversation

@dgoulet-tor
Copy link
Contributor

commented May 29, 2019

When we repurpose a hidden service circuit, we need to clean up from the HS
circuit map and any HS related data structured contained in the circuit.

This commit adds an helper function that does it when repurposing a hidden
service circuit.

Fixes #29034

Signed-off-by: David Goulet dgoulet@torproject.org

hs: Implement a helper to repurpose a circuit
When we repurpose a hidden service circuit, we need to clean up from the HS
circuit map and any HS related data structured contained in the circuit.

This commit adds an helper function that does it when repurposing a hidden
service circuit.

Fixes #29034

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls

This comment has been minimized.

Copy link

commented May 29, 2019

Pull Request Test Coverage Report for Build 5168

  • 11 of 17 (64.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 60.308%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuituse.c 2 3 66.67%
src/feature/hs/hs_circuit.c 9 10 90.0%
src/feature/rend/rendcommon.c 0 4 0.0%
Totals Coverage Status
Change from base Build 5053: 0.004%
Covered Lines: 42874
Relevant Lines: 71092

💛 - Coveralls
test: Add test_hs_circ.c for HS circuit testing
For now, only tests HS circuit repurpose function.

Part of #29034

Signed-off-by: David Goulet <dgoulet@torproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.