Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a logic error in deciding whether to accept SessionGroup= #1065

Merged
merged 2 commits into from Jun 11, 2019
Merged

Fix a logic error in deciding whether to accept SessionGroup= #1065

merged 2 commits into from Jun 11, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented May 31, 2019

Fixes bug 22619; bugfix on 0.2.7.2-alpha
@nmathewson
Fix a logic error in deciding whether to accept SessionGroup=
70b8535 
Fixes bug 22619; bugfix on 0.2.7.2-alpha
@coveralls
Copy link

@coveralls coveralls commented May 31, 2019 •
edited

Pull Request Test Coverage Report for Build 5167

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.592%
Totals Coverage Status
Change from base Build 5159: 0.0%
Covered Lines: 46880
Relevant Lines: 74898
💛 - Coveralls

@nmathewson
Fix some tests for CL_PORT_NO_STREAM_OPTIONS
3c3158f 
The comment in the tests was correct: this option _was_ inverted wrt
SessionGroup=.
@torproject-pusher torproject-pusher merged commit 3c3158f into torproject:master Jun 11, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment