Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 29034: Cleanup hs circuitmap when purpose changes. #1077

Merged

Conversation

@mikeperry-tor
Copy link
Contributor

commented Jun 5, 2019

Leave the other rend and hs_ident data around until circuit free, since code
may still try to inspect it after marking the circuit for close. The
circuitmap is the important thing to clean up, since repurposed
intropoints must be removed from this map to ensure validity.

Bug 29034: Cleanup hs circuitmap when purpose changes.
Leave the other rend and hs_ident data around until circuit free, since code
may still try to inspect it after marking the circuit for close. The
circuitmap is the important thing to clean up, since repurposed
intropoints must be removed from this map to ensure validity.
@coveralls

This comment has been minimized.

Copy link

commented Jun 5, 2019

Pull Request Test Coverage Report for Build 5203

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 60.303%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuituse.c 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 83.28%
Totals Coverage Status
Change from base Build 5053: -0.001%
Covered Lines: 42862
Relevant Lines: 71078

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit a6399da into torproject:maint-0.3.5 Aug 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.