Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket30871 041 01 #1118

Merged

Conversation

@dgoulet-tor
Copy link
Contributor

commented Jun 18, 2019

No description provided.

@coveralls

This comment has been minimized.

Copy link

commented Jun 18, 2019

Pull Request Test Coverage Report for Build 5366

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 62.625%

Totals Coverage Status
Change from base Build 5307: 0.05%
Covered Lines: 46918
Relevant Lines: 74919

💛 - Coveralls

@dgoulet-tor dgoulet-tor force-pushed the dgoulet-tor:ticket30871_041_01 branch from 0636564 to fa8b710 Jun 18, 2019

dgoulet-tor added some commits Jun 18, 2019

guard: Ignore marked for close circuit when changing state to open
When we consider all circuits in "waiting for guard" state to be promoted to
an "open" state, we were considering all circuits, even the one marked for
close.

This ultiamtely triggers a "circuit_has_opened()" called on the circuit that
is marked for close which then leads to possible undesirable behaviors within
a subsystem.

For instance, the HS subsystem would be unable to find the authentication key
of the introduction point circuit leading to a BUG() warning and a duplicate
mark for close on the circuit.

This commit also adds a unit test to make sure we never select marked for
close circuits when upgrading its guard state from waiting for guard to open.

Fixes #30871

Signed-off-by: David Goulet <dgoulet@torproject.org>
Make the great grand practracker happy...
Signed-off-by: David Goulet <dgoulet@torproject.org>

@dgoulet-tor dgoulet-tor force-pushed the dgoulet-tor:ticket30871_041_01 branch from fa8b710 to 05b6f73 Jun 19, 2019

@torproject-pusher torproject-pusher merged commit 05b6f73 into torproject:maint-0.4.1 Jun 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.