WIP: Ticket30901 #1196
Closed
WIP: Ticket30901 #1196
Conversation
Replace all calls to tor_log_update_sigsafe_err_fds() with tor_log_update_safe_fds(). In future commits, tor_log_update_safe_fds() will also update the control debug fds. No behaviour change. Preparation for 30901.
Split tor_log_update_sigsafe_err_fds() into a small function that sets the signal-safe error log fds, and a helper function that searches for those fds. No behaviour change. Preparation for 30901.
Elevate some constants from tor_log_update_safe_fds_helper() into arguments, and pass the correct values from tor_log_update_sigsafe_err_fds(). Document the signal-safe log behaviour in the tor man page. No behaviour change. Preparation for 30901.
Add tor_log_update_control_safe_debug_fds(), which creates a list of control message trace debug log file descriptors. Document the control message trace log behaviour in the tor man page. Part of 30901.
Move SEVERITY_MASK_IDX() to log.h private/unit tests section, so that we can use it in log.c and the unit tests. Fixes bug 31334; bugfix on 0.2.5.2-alpha.
Put low-level raw logging functions in raw_log, and error-specific logging functions in torerr. No behaviour change. Preparation for 30901.
Logs control trace lines using lib/torerr/raw_log.[ch]. Also add unit tests for the new module. Part of 30901.
Pull Request Test Coverage Report for Build 5700
|
We need to escape the control trace debug logs, but we can't use tor_assert() in control-safe log code. Part of 30901.
And make string a pubsub module, so that it can free the memory used by escaped(). Part of 30901.
Split some protocol error handling out of connection_control_process_inbuf(). Cleanup after 30901.
* actually sleep when tor has not logged anything * log at debug level when waiting for tor to log something * backslash-replace bad UTF-8 characters in logs * format control messages as ASCII: tor does not accept UTF-8 control commands Found during 30901, needs bug number.
|
Obsoleted by #1386. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: