Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug30942 rebase2 #1197

Closed
wants to merge 7 commits into from
Closed

Bug30942 rebase2 #1197

wants to merge 7 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asn-d6 @coveralls @torproject-pusher
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Aug 2, 2019

No description provided.

asn-d6 added 7 commits Aug 2, 2019
@asn-d6
Split connection_edge_process_relay_cell() in two functions.
0764b34 
One function does the validation, the other does the handling.
@asn-d6
fixup! Split connection_edge_process_relay_cell() in two functions.
8b35f83 
The relay header is a pointer now, so dereference it when we access it.
@asn-d6
Ignore regular cells in padding circuits.
fec12fc 
Padding circuits were regular cells that got closed before their padding
machine could finish. This means that they can still receive regular cells from
their past life, but they have no way or reason to answer them anymore. Hence
let's ignore them before they even get to the proper subsystems.
@asn-d6
Test that regular cells get ignored in padding circuits.
0a68c45
@asn-d6
squash! Ignore regular cells in padding circuits.
06b0263
@asn-d6
Rename handle_relay_command to handle_relay_cell_command .
efee517 
As per David's review.
@asn-d6
squash! Ignore regular cells in padding circuits.
49125b1
@coveralls
Copy link

@coveralls coveralls commented Aug 2, 2019

Pull Request Test Coverage Report for Build 5677

  • 49 of 63 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.837%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitpadding.c 6 10 60.0%
src/core/or/relay.c 43 53 81.13%
Totals Coverage Status
Change from base Build 5667: 0.02%
Covered Lines: 47209
Relevant Lines: 75129
💛 - Coveralls

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment