Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug26294 rebased #1199

Closed
wants to merge 15 commits into from
Closed

Bug26294 rebased #1199

wants to merge 15 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asn-d6 @coveralls @torproject-pusher
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Aug 5, 2019

No description provided.

asn-d6 added 13 commits Aug 5, 2019
@asn-d6
test: Improve helper_create_service_ip() test helper.
349259a 
Make it take an optional node argument so that we can also have node keys as
part of the intro point object.
@asn-d6
test: Make node_get_link_specifier_smartlist() mockable.
4878781
@asn-d6
replaycache: Introduce replaycache_size() method.
2abfe2e 
Will be used to wipe the replaycache after a certain number of objects have
been cached.
@asn-d6
hs_service test: Add test for the current intro point replay cache.
e54ec24 
It tests the current behavior: Intro point should expire after some introductions.
@asn-d6
hs_service: Remove introduce2_count since it's no longer needed.
4db35ea 
We no longer want to expire the intro point after a certain number of
introductions, and that's the only reason that field was used for.
@asn-d6
hs_service: Implement the new replay cache behavior for v3.
9bb8595 
We now want to wipe the replay cache after a certain number of introductions
but keep the intro point intact.

Also increase the size of the replay cache to fit 150k-300k introductions.
@asn-d6
rendservice: Implement new replay cache behavior for v2.
9193673 
We now want to wipe the replay cache after a certain number of intros, but keep
the intro point intact.
@asn-d6
hs_service: Rename some objects to denote their new behavior.
fd4bafc 
INTRO_POINT_MIN_LIFETIME_INTRODUCTIONS -> INTRO_POINT_REPLAY_CACHE_MIN_INTRODUCTIONS
INTRO_POINT_MAX_LIFETIME_INTRODUCTIONS -> INTRO_POINT_REPLAY_CACHE_MAX_INTRODUCTIONS
ip->introduce2_max -> ip->replay_cache_max_introduce2

This commit does not change any behavior.
@asn-d6
Do practracker/changes for #26294.
f2f42e2
@asn-d6
fixup! hs_service: Implement the new replay cache behavior for v3.
45f5900
@asn-d6
fixup! rendservice: Implement new replay cache behavior for v2.
17905ba
@asn-d6
fixup! rendservice: Implement new replay cache behavior for v2.
3b7c572
@asn-d6
fixup! Do practracker/changes for #26294.
d48f549
@coveralls
Copy link

@coveralls coveralls commented Aug 5, 2019 •
edited

Pull Request Test Coverage Report for Build 5709

  • 21 of 28 (75.0%) changed or added relevant lines in 5 files are covered.
  • 284 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 63.064%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/hs/hs_circuit.c 0 1 0.0%
src/feature/rend/rendservice.c 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/rend/rendservice.c 1 32.6%
src/core/or/circuitpadding.c 32 92.36%
src/core/or/relay.c 251 51.41%
Totals Coverage Status
Change from base Build 5667: 0.3%
Covered Lines: 47394
Relevant Lines: 75152
💛 - Coveralls

asn-d6 added 2 commits Aug 5, 2019
@asn-d6
fixup! rendservice: Implement new replay cache behavior for v2.
aa114f6
@asn-d6
fixup! rendservice: Implement new replay cache behavior for v2.
18fc713
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment