Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug30942 comment #1204

Closed
wants to merge 2 commits into from
Closed

Bug30942 comment #1204

wants to merge 2 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mikeperry-tor @coveralls
@mikeperry-tor
Copy link
Contributor

@mikeperry-tor mikeperry-tor commented Aug 5, 2019

No description provided.

@mikeperry-tor
Bug 30942: Improve comment and logline.
e88bd70
@mikeperry-tor
Bug 30942: Make log a protocol warn.
846aa16 
I think it is a violation of the protocol to ignore invalid requests, and we
should find the most common of these in testing, to check them for validity.
Integration testing with the vanguards addon would help with this.
But that is a long term project...

If our testing infra would explode from frequent protocol warns, maybe omit
this commit. (But I don't think these will be that frequent).
@coveralls
Copy link

@coveralls coveralls commented Aug 5, 2019

Pull Request Test Coverage Report for Build 5702

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 62.626%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/relay.c 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 51.02%
Totals Coverage Status
Change from base Build 5692: 0.0%
Covered Lines: 46926
Relevant Lines: 74930
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment