Bug30942 logline master #1205
Closed
Bug30942 logline master #1205
Conversation
I think it is a violation of the protocol to ignore invalid requests, and we should find the most common of these in testing, to check them for validity. Integration testing with the vanguards addon would help with this. But that is a long term project... If our testing infra would explode from frequent protocol warns, maybe omit this commit. (But I don't think these will be that frequent).
Merge forward issue.
Unused variable.
Pull Request Test Coverage Report for Build 5705
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: