Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket31176 #1206

Merged
merged 14 commits into from Aug 21, 2019
Merged

Ticket31176 #1206

merged 14 commits into from Aug 21, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Aug 5, 2019

No description provided.

nmathewson added 14 commits Aug 5, 2019
@nmathewson
Move the executable part of checkIncludes.py inside an if block.
4757493 
I'll want to make this block into a series of functions in a
subsequent commit, but I'm doing this separately to get the
indentation change out of the way.

This branch will end up with making checkIncludes.py an integrated
part of practracker, for ticket 31176.
@nmathewson
checkIncludes: introduce rules-file caching.
3f35ac7 
We'll want this so that we can have each file evaluated
independently, rather than a directory at a time.
@nmathewson
checkIncludes.py: extract topological sort code
65a69f8 
Our topological sort code really deserves a function of its own.

Additionally, don't print from inside the topological sort code:
instead, return a result, and let the caller print it.
@nmathewson
checkIncludes: Separate file-handling from rule-handling
47d9bcf 
This is our shift from directory-at-a-time processing to
file-at-a-time processing.
@nmathewson
checkIncludes: refactor to use error-iteration style
3f4e89a 
This makes checkIncludes match practracker more closely, and lets us
eliminate a global.
@nmathewson
checkIncludes: add a real main function and CLI
9eb12dd
@nmathewson
Move checkIncludes inside practracker
6fb7475 
Update the makefile accordingly.
@nmathewson
Update pre-commit hook to find checkIncludes in its new location
9abbde2 
Also add a temporary script to redirect the hook, if people don't
upgrade for a bit.
@nmathewson
Teach include-checker about advisory rules
720951f 
A .may_includes file can be "advisory", which means that some
violations of the rules are expected.  We will track these
violations with practracker, not as automatic errors.
@nmathewson
practracker: a violation of a .may_include rule is now a problem.
6b26281 
We treat "0" as the expected number, and warn about everything
else.  The problem type is "dependency-violation".
@nmathewson
Make includes interface more like the rest of practracker
2a3c727 
Everything else assumes that somebody else will open the file for it.
@nmathewson
Move include-violation checking into its own function.
a5971d7
@nmathewson
changes file for ticket 31176
d515b0f
@nmathewson
update exceptions file for depencency violations
0f4b245
@coveralls
Copy link

@coveralls coveralls commented Aug 5, 2019

Pull Request Test Coverage Report for Build 5706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.821%
Totals Coverage Status
Change from base Build 5698: 0.0%
Covered Lines: 47197
Relevant Lines: 75129
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 0f4b245 into torproject:master Aug 21, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment