Print summary at the end of the configure script #1218
Conversation
Signed-off-by: David Goulet <dgoulet@torproject.org>
Pull Request Test Coverage Report for Build 6678
|
configure.ac
Outdated
| PPRINT_SUBTITLE([Build Features]) | ||
|
|
||
| test "x$enable_gcc_warnings" != "xno" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([GCC Warnings], $value) |
We should call this "verbose warnings"; it applies to clang too.
Maybe it would be a good idea to also print, for this setting and all the others, how to override it?
Yup. There is one fixup commit that fixes it all. I recommend you rerun the configure script to see the end result. I changed many things from your review :).
configure.ac
Outdated
| PPRINT_PROP_BOOL([GCC Warnings], $value) | ||
|
|
||
| test "x$enable_fatal_warnings" != "xno" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([GCC Fatal Warnings], $value) |
Let's call this "Warnings are fatal"
+1
configure.ac
Outdated
| PPRINT_PROP_BOOL([GCC Fatal Warnings], $value) | ||
|
|
||
| test "x$enable_coverage" = "xyes" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([Code Coverage], $value) |
This maybe belongs in a testing section.
+1
configure.ac
Outdated
| fi | ||
|
|
||
| AS_ECHO | ||
| PPRINT_SUBTITLE([Security]) |
Maybe we should have an "optional libraries" section for NSS and libscrypt and libsystemd. This section makes it sould like your system is less secure if it doesn't have NSS, which isn't really true.
+1
configure.ac
Outdated
| PPRINT_PROP_BOOL([libscrypt support], $value) | ||
|
|
||
| test "x$enable_fragile_hardening" != "xno" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([libasan support], $value) |
Let's call this "fragile hardening" to match the option. Also let's mark it as "not for production use" somehow-- people should use this in production.
+1
configure.ac
Outdated
| PPRINT_PROP_BOOL([libasan support], $value) | ||
|
|
||
| test "x$enable_gcc_hardening" = "xyes" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([GCC Hardening], $value) |
Let's call this "compiler hardening"?
This option is supposed to be on by default, but when I ran the configure script, it said that it was off. I think there might be a bug.
+1
I fixed the bug I believe.
configure.ac
Outdated
| PPRINT_PROP_BOOL([Unit tests], $value) | ||
|
|
||
| test "x$enable_asserts_in_tests" = "xyes" && value=1 || value=0 | ||
| PPRINT_PROP_BOOL([Unit tests assert()], $value) |
This option was mis-reported when I ran the script. It is almost always on.
Its name is a little confusing, too. How about invert this, can call it "assert()s disabled for unit tests"
We should also mark this option as not safe to use --disable-asserts-in-tests in production.
+1
| AS_ECHO | ||
| PPRINT_SUBTITLE([Install Directories]) | ||
|
|
||
| report_mandir="`eval eval echo $mandir`" |
eval eval? I don't understand this.
Because just one eval gives: ${prefix}/share/man so the second one evaluates that prefix.
| report_mandir="`eval eval echo $mandir`" | ||
| PPRINT_PROP_STRING([Binaries], [$BINDIR]) | ||
| PPRINT_PROP_STRING([Configuration], [$CONFDIR]) | ||
| PPRINT_PROP_STRING([Man Pages], [$report_mandir]) |
Is there any way that we can get the complete configure command line as it was provided to us? For a lot of cases, that would be more useful for debugging than all the rest of this stuff.
I added a last line that does that :).
Signed-off-by: David Goulet dgoulet@torproject.org
The text was updated successfully, but these errors were encountered: