Bug31356+logs rebased2 #1230
Merged
Bug31356+logs rebased2 #1230
Conversation
Also add controller circuit id to all relevant circpad loglines. This will make debugging any future issues like #30992 much easier.
This can happen, it's not great, but it's not the worst thing in the world either. Deferring full fix for 0.4.2/later.
By binding the protover numbering to specific padding machines, we can make our padding negotiation simpler. We probably should have done this in the first place. This has the side effect that earlier 0.4.1.x-alpha clients won't negotiate with 0.4.1.x-stable relays, and 0.4.1.x-stable clients won't negotiate with earlier 0.4.1.x-alpha relays (or 0.4.0.x relays). Since we don't support alphas after the stable is released, this is fine, so long as it gets in before the first stable of 0.4.1.x.
Also document the other log changes in this branch.
teor2345
reviewed
Aug 19, 2019
| @@ -841,8 +841,8 @@ typedef struct protover_summary_flags_t { | |||
| unsigned int supports_v3_rendezvous_point: 1; | |||
|
|
|||
| /** True iff this router has a protocol list that allows clients to | |||
| * negotiate link-level padding. Requires Padding>=1. */ | |||
| unsigned int supports_padding : 1; | |||
| * negotiate hs circuit setup padding. Requires Padding>=2. */ | |||
This comment is a bit confusing.
When we remove Padding=2, 0.4.1 will stop negotiating padding, even if we have added Padding=3.
I think this is a decent fix, but I'd be happy with any clarification:
Suggested change
| * negotiate hs circuit setup padding. Requires Padding>=2. */ | |
| * negotiate hs circuit setup padding. Requires Padding=2-* | |
| * Padding=2 will always be used for HS circuit setup. | |
| * Future padding versions will introduce support for other | |
| * machines. | |
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: