Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket21003 #1234

Merged
merged 7 commits into from Aug 27, 2019
Merged

Ticket21003 #1234

merged 7 commits into from Aug 27, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Aug 19, 2019

No description provided.

teor2345 added 4 commits Aug 19, 2019
@teor2345
test/nodelist: Fix a typo
8a10c06
@teor2345
nodelist: Move router_get_verbose_nickname() declaration
81256c0 
The declaration was in nodelist/routerinfo.h, but the implementation
was in nodelist/describe.h.

Part of 21003.
@teor2345
nodelist: Remove support for is_named in describe.c
03be44e 
The Named flag is deprecated. Removing support from the formatting code
simplifies the unit tests.

Part of 21003.
@teor2345
nodelist: Add support for multiple addresses in describe.c
23844bc 
Also prepare for unit tests.

Part of 21003.
@coveralls
Copy link

@coveralls coveralls commented Aug 19, 2019 •
edited

Pull Request Test Coverage Report for Build 5900

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 62.849%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 85.28%
src/feature/hs/hs_service.c 1 73.56%
Totals Coverage Status
Change from base Build 5886: 0.02%
Covered Lines: 47282
Relevant Lines: 75231
💛 - Coveralls

teor2345 added 3 commits Aug 22, 2019
@teor2345
nodelist: Clear buffers and detect more caller errors in describe.c
e8ba094 
Part of 21003.
@teor2345
test/nodelist: Add unit tests for describe.c
1ebff4d 
Part of 21003.
@teor2345
changes: file for 21003
5794523 
Log IPv6 addresses as well as IPv4 addresses, when describing
routerinfos, routerstatuses, and nodes.

Closes ticket 21003.
@torproject-pusher torproject-pusher merged commit 5794523 into torproject:master Aug 27, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment