Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new practracker violation types, and add a practracker readme #1246

Merged
merged 2 commits into from Sep 4, 2019
Merged

Document new practracker violation types, and add a practracker readme #1246

merged 2 commits into from Sep 4, 2019

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @tlyu @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Aug 21, 2019

Closes ticket 31476.
@nmathewson
Document new practracker violation types, and add a practracker readme
5b3741e 
Closes ticket 31476.
@coveralls
Copy link

@coveralls coveralls commented Aug 24, 2019 •
edited

Pull Request Test Coverage Report for Build 5988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1752 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.04%) to 62.96%
Files with Coverage Reduction New Missed Lines %
src/app/config/confparse.c 6 97.4%
src/feature/hs/hs_ident.c 6 76.92%
src/lib/confmgt/structvar.c 6 77.63%
src/lib/confmgt/typedvar.c 23 67.39%
src/feature/dirauth/shared_random_state.c 49 89.53%
src/app/config/statefile.c 67 52.44%
src/core/or/circuituse.c 82 31.43%
src/feature/dirauth/process_descs.c 101 4.15%
src/feature/hs/hs_circuit.c 131 41.88%
src/feature/hs/hs_service.c 151 73.4%
Totals Coverage Status
Change from base Build 5920: 0.04%
Covered Lines: 47415
Relevant Lines: 75310
💛 - Coveralls

@nmathewson
practracker: make filename terminology uniform
e3f7e5e 
Previously we often referred to "C files" and "H files", which is
more ambiguous than ".c files" and ".h files".
tlyu
tlyu approved these changes Sep 3, 2019
View changes
@torproject-pusher torproject-pusher merged commit e3f7e5e into torproject:master Sep 4, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment