Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket31477 #1264

Merged
merged 5 commits into from Sep 9, 2019
Merged

Ticket31477 #1264

merged 5 commits into from Sep 9, 2019

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Aug 26, 2019

No description provided.

These tests check our .may_include checking, and our header file
checking.

They do not pass yet: we have a bug in our filtering code.
@coveralls
Copy link

@coveralls coveralls commented Aug 30, 2019

Pull Request Test Coverage Report for Build 6091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 63.075%

Totals Coverage Status
Change from base Build 6080: 0.001%
Covered Lines: 47622
Relevant Lines: 75501

💛 - Coveralls

nmathewson added 3 commits Sep 5, 2019
I was expecting our filter code to work in a way it didn't.  I
thought that saying that DependencyViolation applied to "*" would
hit all of the files -- but actually, "*" wasn't implemented.  I had
to say "*.c" and "*.h"
I've done this manually, since I don't want to override the existing
exceptions in this branch.
@torproject-pusher torproject-pusher merged commit 380d178 into torproject:master Sep 9, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment