Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr1182 squashed v2 #1267

Merged
merged 5 commits into from Aug 27, 2019
Merged

Pr1182 squashed v2 #1267

merged 5 commits into from Aug 27, 2019
+58 −3

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @torproject-pusher @neelchauhan
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Aug 27, 2019

No description provided.

neelchauhan and others added 5 commits Aug 26, 2019
@neelchauhan @nmathewson
Check for private IPv6 addresses in dirserv_router_has_valid_address()
d9a7d47
@neelchauhan @nmathewson
Add changes file for Bug #31088
cc5af6d
@neelchauhan @nmathewson
Add test for dirserv_router_has_valid_address()
c8e69e6
@nmathewson
In tests, make sure that "ri" is freed on all paths.
5eca338 
In Tor's tests, the tt_*() macros can call "goto done" on failure.
When that happens, we need to make sure that all of our allocated
memory still gets freed, or else Coverity will complain.
@nmathewson
test_address: parenthesize macro arguments.
8af92b6 
It's good style to always add parentheses when using macro
arguments, in case somebody someday provides an argument that
contains an operator you don't expect, or causes the expression to
parse differently.
@torproject-pusher torproject-pusher merged commit 8af92b6 into torproject:master Aug 27, 2019
2 checks passed
@coveralls
Copy link

@coveralls coveralls commented Aug 30, 2019

Pull Request Test Coverage Report for Build 5955

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 62.964%
Totals Coverage Status
Change from base Build 5944: 0.03%
Covered Lines: 47406
Relevant Lines: 75291
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment