Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug31571 master #1287

Merged
merged 9 commits into from Sep 9, 2019
Merged

Bug31571 master #1287

merged 9 commits into from Sep 9, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 3, 2019

No description provided.

teor2345 added 4 commits Aug 30, 2019
@teor2345
backtrace: Always set a backtrace Tor version
e2a7d08 
We want to report the tor version, even on platforms that don't have
backtrace support (like Android).

This commit stores the backtrace Tor version, regardless of USE_BACKTRACE.

Preparation for 31571.
@teor2345
backtrace: Log the Tor backtrace version whenever we log a backtrace
743bc00 
Previously, we just logged it in the crash handler.

Part of 31571.
@teor2345
torerr: Log the Tor backtrace version when a raw assertion fails
65a1d86 
Part of 31571.
@teor2345
torerr: Try harder to flush raw assert messages before process termin…
c555918 
…ation

Some platforms (macOS, maybe others?) can swallow the last write before an
abort. This issue is probably caused by a race condition between write
buffer cache flushing, and process termination. So we write an extra
newline, to make sure that the message always gets through.

Fixes bug 31571; bugfix on 0.3.5.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Sep 3, 2019 •
edited

Pull Request Test Coverage Report for Build 6039

  • 11 of 15 (73.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.974%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/err/backtrace.c 11 13 84.62%
src/lib/err/torerr.c 0 2 0.0%
Totals Coverage Status
Change from base Build 6035: 0.02%
Covered Lines: 47434
Relevant Lines: 75323
💛 - Coveralls

teor2345 added 5 commits Sep 4, 2019
@teor2345
backtrace: Check the return values of snprintf() and strncpy()
f311d06 
We can't use strlcat() or strlcpy() in torerr, because they are defined
in string/compat_string.h on some platforms, and string uses torerr.

Part of 31571.
@teor2345
Merge branch 'maint-0.3.5' into bug31571_035
a836dd2
@teor2345
Merge branch 'bug31571_035' into bug31571_040
0cee6f4
@teor2345
Merge branch 'bug31571_040' into bug31571_041
abe1f4f
@teor2345
Merge branch 'bug31571_041' into bug31571_master
193c74f
@teor2345 teor2345 force-pushed the bug31571_master branch from 88c760d to 193c74f Sep 4, 2019
@torproject-pusher torproject-pusher merged commit 193c74f into torproject:master Sep 9, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment