Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug31594 040 #1303

Open
wants to merge 4 commits into
base: maint-0.4.0
Choose a base branch
from
Open

Bug31594 040 #1303

wants to merge 4 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @coveralls
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 9, 2019

No description provided.

teor2345 added 4 commits Sep 9, 2019
@teor2345
torerr: Close sigsafe fds on shutdown
d02ced4 
And clear the list of error fds.

Part of 31594.
@teor2345
log: Don't close file log fds that are being used by the err module
a22fbab 
Instead, dup() file log fds, before passing them to the err module.

Closes 31613, part of 31594.
@teor2345
log: Close log and err file descriptors before aborting
1609916 
Part of 31594.
@teor2345
changes: file for 31594
ebce705
@coveralls
Copy link

@coveralls coveralls commented Sep 9, 2019

Pull Request Test Coverage Report for Build 6107

  • 29 of 44 (65.91%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 61.743%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/err/backtrace.c 0 1 0.0%
src/lib/log/util_bug.c 0 2 0.0%
src/lib/err/torerr.c 11 15 73.33%
src/lib/log/log.c 17 25 68.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.45%
src/core/or/circuitpadding.c 10 93.65%
Totals Coverage Status
Change from base Build 6067: -0.01%
Covered Lines: 45414
Relevant Lines: 73553
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment