Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: The <sys/sysctl.h> is now deprecated on Linux #1307

Merged
merged 1 commit into from Sep 17, 2019
Merged

build: The <sys/sysctl.h> is now deprecated on Linux #1307

merged 1 commit into from Sep 17, 2019

Conversation

Reviewers

@nmathewson nmathewson

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@dgoulet-tor @coveralls @nmathewson @teor2345 @torproject-pusher
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Sep 9, 2019

Closes #31673
@coveralls
Copy link

@coveralls coveralls commented Sep 9, 2019 •
edited

Pull Request Test Coverage Report for Build 6127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.288%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.79%
Totals Coverage Status
Change from base Build 6066: -0.02%
Covered Lines: 42872
Relevant Lines: 71112
💛 - Coveralls

@dgoulet-tor dgoulet-tor force-pushed the ticket31673_035_01 branch from 8b3042a to 15f0916 Sep 9, 2019
teor2345
teor2345 reviewed Sep 9, 2019
View changes
configure.ac Outdated
sys/syslimits.h \
sys/sysctl.h \
Copy link
Contributor

@teor2345 teor2345 Sep 9, 2019

I don't think this change actually does anything?
So let's keep the headers in alphabetical order.

Copy link
Contributor

@nmathewson nmathewson Sep 9, 2019

+1

nmathewson
nmathewson reviewed Sep 9, 2019
View changes
src/lib/meminfo/meminfo.c Outdated
@@ -36,6 +33,10 @@
#endif
#include <string.h>

#if HAVE_SYS_SYSCTL_H && !defined(_WIN32) && !defined(__linux__)
Copy link
Contributor

@nmathewson nmathewson Sep 9, 2019

We should check "defined(HAVE_SYS_SYSCTL_H)", not "SYS_SYSCTL_H": appveyor is failing with this error:

bash.exe : ../src/lib/meminfo/meminfo.c:36:5: error: "HAVE_SYS_SYSCTL_H" is not defined, evaluates to 0 [-Werror=undef]

@dgoulet-tor
build: The <sys/sysctl.h> is now deprecated on Linux
409df19 
Closes #31673
@dgoulet-tor dgoulet-tor force-pushed the ticket31673_035_01 branch from 15f0916 to 409df19 Sep 9, 2019
@torproject-pusher torproject-pusher merged commit 409df19 into torproject:maint-0.3.5 Sep 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment