Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket31675 #1309

Merged
merged 11 commits into from Sep 25, 2019
Merged

Ticket31675 #1309

merged 11 commits into from Sep 25, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 9, 2019

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Sep 9, 2019 •
edited

Pull Request Test Coverage Report for Build 6318

  • 86 of 90 (95.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 63.373%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/dirparse/microdesc_parse.c 86 90 95.56%
Totals Coverage Status
Change from base Build 6312: 0.01%
Covered Lines: 47968
Relevant Lines: 75691
💛 - Coveralls

nmathewson added 3 commits Sep 10, 2019
@nmathewson
Add a unit test for ed25519 identity parsing in microdescriptors
d8ef6b1 
This test makes sure that we parse ed25519 identities to get the
correct data from them.  It also tests:

   * That a microdescriptor may not have two ed25519 identities.
   * That a microdescriptor may not have an ed25519 identity that is
     not a valid base64-encoded ed25519 key.
   * That a microdescriptor may have an unrecognized identity type.

It will help test the refactoring of ticket31675.
@nmathewson
Extract saved_location_to_string() from microdesc parsing.
7282213 
We may be able to use this function in other places in the future;
if so, we should move it to somewhere more useful.

Part of 31675.
@nmathewson
Do not look inside bogus microdesc when listing its digest as invalid
e7d7e04 
We have code in microdescs_parse_from_string() to record the digests
of microdescriptors that we could not parse.  But right now, that
code looks at the md->digest field, which is a bit inelegant, and
will stand in the way of sensible refactoring.

Instead, use a local variable to hold the digest.
nmathewson added 8 commits Sep 19, 2019
@nmathewson
Extract the body-copying portion of microdesc parsing
9cbc166 
This code is logically independent of the rest of the function, and
goes better in its own function.

This is almost purely code movement; I suggest reviewing with
--color-moved.
@nmathewson
Reindent microdesc_extract_body().
b1552e8 
This commit is whitespace-only; I suggest reviewing with -b.
@nmathewson
Extract field-parsing code for microdesc_parse.c
ec36840 
The code here parses the fields from the microdescriptor, including
possible annotations, and stores them into a microdesc_t object.

This commit is almost pure code movement; I recommend using
--color-moved to review it.
@nmathewson
Reindent microdesc_parse_fields().
2094796 
I suggest reviewing this with -b: it should be whitespace-only.
@nmathewson
microdesc_parse: Rename "next" label to "err".
1948849
@nmathewson
Remove practracker exception for microdesc parsing function
2e1989d
@nmathewson
changes file for microdesc_parse refactoring.
6100378
@nmathewson
microdesc_parse: convert some ints to bools
c309169 
Noted by ahf during review of #31675
@torproject-pusher torproject-pusher merged commit c309169 into torproject:master Sep 25, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment