Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

madvise: tolerate EINVAL and ENOSYS when minherit fails #1318

Merged
merged 1 commit into from Sep 17, 2019

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 11, 2019

These errors can occur if we are built on a system with support for
madvise(MADV_NOFORK) but then we are run on a system whose kernel
does not support that flag.

If the error is something that we don't tolerate at all, we now log
it before crashing.

Fixes bug 31696. I am calling this a bugfix on 0.4.1.1-alpha, where
we actually started using the map_anon code.

This is similar to, but not the same as, the fix for #31570.

These errors can occur if we are built on a system with support for
madvise(MADV_NOFORK) but then we are run on a system whose kernel
does not support that flag.

If the error is something that we don't tolerate at all, we now log
it before crashing.

Fixes bug 31696.  I am calling this a bugfix on 0.4.1.1-alpha, where
we actually started using the map_anon code.

This is similar to, but not the same as, the fix for #31570.
@nmathewson nmathewson changed the base branch from master to maint-0.4.1 Sep 11, 2019
@coveralls
Copy link

@coveralls coveralls commented Sep 16, 2019

Pull Request Test Coverage Report for Build 6159

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.613%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/malloc/map_anon.c 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_service.c 1 73.32%
src/feature/dirauth/shared_random.c 3 85.54%
src/feature/dirauth/dirvote.c 9 64.74%
Totals Coverage Status
Change from base Build 6068: -0.02%
Covered Lines: 46929
Relevant Lines: 74951

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 0891a31 into torproject:maint-0.4.1 Sep 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment