Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket31754 workaround #1325

Closed
wants to merge 4 commits into from
Closed

Ticket31754 workaround #1325

wants to merge 4 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nmathewson @coveralls
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 16, 2019

No description provided.

nmathewson added 4 commits Sep 16, 2019
@nmathewson
Fix a shellcheck warning in test_parseconf.sh.
a1694b7 
I wonder why this didn't show up before.
@nmathewson
On windows, allow failures in test_parseconf.sh
72b6914 
There seems to be some unreliability issue with this test on
appveyor.

Addresses ticket 31757; This isn't a final fix for this issue, but
it should make CI pass.
@nmathewson
fixup! On windows, allow failures in test_parseconf.sh
d3fa997 
Also change exit code from "die()" function.
@nmathewson
fixup! fixup! On windows, allow failures in test_parseconf.sh
f15f040 
Tolerate nonzero exit code from diff.
@nmathewson
Copy link
Contributor Author

@nmathewson nmathewson commented Sep 16, 2019

Closing in favor of #1327

@nmathewson nmathewson closed this Sep 16, 2019
@coveralls
Copy link

@coveralls coveralls commented Sep 16, 2019 •
edited

Pull Request Test Coverage Report for Build 6210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.362%
Totals Coverage Status
Change from base Build 6209: 0.0%
Covered Lines: 47954
Relevant Lines: 75683
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment