Ticket31759: improvements to annotate_ifdef_directives #1339
Conversation
Pull Request Test Coverage Report for Build 6412
|
No functional change in this commit.
If we would add a comment making a line longer than 80 columns, instead truncate the variable portion of the comment until it just fits into 80 columns, with an ellipsis.
tlyu
reviewed
Sep 24, 2019
| """ | ||
| return fmt % argument | ||
| result = fmt % argument | ||
| if len(result) <= maxwidth: |
I think this will allow a 80-character line. doc/HACKING/Codingstyle.md says 79 characters per line, and checkSpaces.pl seems to enforce 79.
Should we have a test case for 79 and 80 character lines?
Or is this script too small to have test cases?
Should we have a test case for 79 and 80 character lines?
Or is this script too small to have test cases?
I think that's a great idea to have a test case for 79 vs 80 character lines.
This change should reduce the number of cases where we say "/* !(!defined(foo)) */" . This only does cases where we can use a regex to make sure that the simplification is guaranteed to be correct. Full boolean simplification would require this script to parse C, and nobody wants that.
Our line limit is 80 characters, assuming that there is a single terminating newline character that counts towards the limit. On Windows, this might go as high as 81 characters, if we count CRLF as two characters.
tlyu
reviewed
Sep 27, 2019
| if len(result) <= maxwidth: | ||
| return result | ||
| else: | ||
| # How long can we let the agument be? Try filling in the |
Typo: "agument" should be "argument"
This algorithm is not fully general, but it strikes a balance between efficiency, simplicity, and correctness.
This allows the python doctest module to process it correctly when invoked as: python -m doctest -v annotate_ifdef_directives.py
An 80-character line (79 characters if you don't count the newline) should not be truncated, and should not have a "..." insterted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: