Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug31793 #1345

Merged
merged 4 commits into from Sep 25, 2019
Merged

Bug31793 #1345

merged 4 commits into from Sep 25, 2019

Conversation

Reviewers

@liyvang liyvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @liyvang @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 19, 2019

No description provided.

teor2345 added 4 commits Sep 19, 2019
@teor2345
test: dirserv_router_has_valid_address() with zero-family addresses
46fea1d 
Sometimes tor doesn't initialise an address, so its family is zero.

Failing test for 31793. Future commits will fix the code.
@teor2345
dirauth: reorder the checks in dirserv_router_has_valid_address()
03c2b1b 
To avoid a bug warning.

Fixes 31793. Bug not in any release, no changes file required.
@teor2345
test: refactor dirserv_router_has_valid_address() tests
c2ceede 
Cleanup after 31793.
@teor2345
test: test dirserv_router_has_valid_address() with DirAllowPrivateAdd…
69a1f9c 
…resses

Part of 31793.
@coveralls
Copy link

@coveralls coveralls commented Sep 19, 2019 •
edited

Pull Request Test Coverage Report for Build 6304

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 63.378%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 85.28%
Totals Coverage Status
Change from base Build 6286: 0.02%
Covered Lines: 47966
Relevant Lines: 75683
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 69a1f9c into torproject:master Sep 25, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment