Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock: Don't call pthread_mutex_destroy() on a global mutex #1346

Open
wants to merge 1 commit into
base: maint-0.3.5
Choose a base branch
from
Open

lock: Don't call pthread_mutex_destroy() on a global mutex #1346

wants to merge 1 commit into from

Conversation

Reviewers

@nmathewson nmathewson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @nmathewson
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 20, 2019

Closes bug 31736.
@coveralls
Copy link

@coveralls coveralls commented Sep 20, 2019 •
edited

Pull Request Test Coverage Report for Build 6394

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 60.307%
Totals Coverage Status
Change from base Build 6284: 0.001%
Covered Lines: 42887
Relevant Lines: 71114
💛 - Coveralls

nmathewson
nmathewson reviewed Sep 22, 2019
View changes
src/app/config/config.c Outdated
/* Destroying a locked mutex is undefined behaviour. Therefore, global
* mutexes can not be destroyed, because multiple threads may still be able
* to access them. See #31735. */
//atomic_counter_destroy(&protocol_warning_severity_level);
Copy link
Contributor

@nmathewson nmathewson Sep 22, 2019

Should we restore this to its original level of LOG_WARN?

@teor2345
lock: Avoid some undefined behaviour when freeing mutexes.
d1eab05 
Fixes bug 31736; bugfix on 0.0.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment