Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tor Trac #31408] Fix bug when %including folder with comment only files. #31408 #1347

Closed
wants to merge 1 commit into from

Conversation

Labels
None yet
Projects
None yet
2 participants
@Jigsaw52
Copy link
Contributor

@Jigsaw52 Jigsaw52 commented Sep 22, 2019

When processing a %included folder, a bug caused the pointer to
the last element of the options list to be set to NULL when
processing a file with only comments or whitepace. This could
cause options from other files on the same folder to be
discarded depending on the lines after the affected %include.

@Jigsaw52 Jigsaw52 changed the title Fix bug when %including folder with comment only files. #31408 [Tor Trac #31408] Fix bug when %including folder with comment only files. #31408 Sep 22, 2019
When processing a %included folder, a bug caused the pointer to
the last element of the options list to be set to NULL when
processing a file with only comments or whitepace. This could
cause options from other files on the same folder to be
discarded depending on the lines after the affected %include.
@coveralls
Copy link

@coveralls coveralls commented Sep 22, 2019

Pull Request Test Coverage Report for Build 6329

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0004%) to 63.361%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 85.28%
Totals Coverage Status
Change from base Build 6312: -0.0004%
Covered Lines: 47955
Relevant Lines: 75685

💛 - Coveralls

@Jigsaw52 Jigsaw52 closed this Jun 6, 2020
@Jigsaw52 Jigsaw52 deleted the ticket31408 branch Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment