Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop libevent from reading data from closed connections. #1380

Closed
wants to merge 2 commits into from
Closed

Stop libevent from reading data from closed connections. #1380

wants to merge 2 commits into from

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@asn-d6 @coveralls @teor2345 @torproject-pusher
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Sep 30, 2019

Code adapted from Rob's proposed patch in #30344.

Also add a comment in connection_mark_for_close_internal_() on why we should
not be adding extra code there without a very good reason.
@asn-d6
Stop libevent from reading data from closed connections.
0efa782 
Code adapted from Rob's proposed patch in #30344.

Also add a comment in connection_mark_for_close_internal_() on why we should
not be adding extra code there without a very good reason.
@coveralls
Copy link

@coveralls coveralls commented Sep 30, 2019 •
edited

Pull Request Test Coverage Report for Build 6575

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 63.377%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/mainloop/mainloop.c 0 2 0.0%
Totals Coverage Status
Change from base Build 6570: -0.002%
Covered Lines: 47997
Relevant Lines: 75733
💛 - Coveralls

teor2345
teor2345 reviewed Oct 1, 2019
View changes
src/core/mainloop/connection.c Outdated
* For all other cases, use connection_mark_and_flush() instead, which
* checks for or_connection_t properly, instead. See below.
* For all other cases, use connection_mark_and_flush() instead, which checks
* for or_connection_t properly, instead. See below.
Copy link
Contributor

@teor2345 teor2345 Oct 1, 2019

Repeated "instead"

@asn-d6
fixup! Stop libevent from reading data from closed connections.
9fc0552
@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment