Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug26258 033 #149

Merged
merged 2 commits into from Jun 14, 2018
Merged

Bug26258 033 #149

merged 2 commits into from Jun 14, 2018

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @tlyu @tor-bot
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Jun 13, 2018

No description provided.

nmathewson added 2 commits Jun 1, 2018
@nmathewson
Make sure that the test_rust.sh script fails when a test fails
9d06c41 
Exit codes from find(1) seem not to be so reliable as we had hoped.

Closes ticket 26258; bugfix on 0.3.3.4-alpha when we fixed #25560
@nmathewson
squash! Make sure that the test_rust.sh script fails when a test fails
ee860b8 
Also make sure that we're actually running the test from within the right
cwd, like we do when we're building.  This seems necessary to avoid
an error when running offline.

Amusingly, it appears that we had this bug before: we just weren't
noticing it, because of bug 26258.
@coveralls
Copy link

@coveralls coveralls commented Jun 13, 2018

Coverage Status

Coverage decreased (-0.02%) to 58.187% when pulling ee860b8 on nmathewson:bug26258_033 into ca6d289 on torproject:maint-0.3.3.

tlyu
tlyu approved these changes Jun 13, 2018
View changes
Copy link
Contributor

@tlyu tlyu left a comment

Looks good to me! We'll likely have to change this if this directory tree gets deeper, but the old version was limited to a specific depth too.

@tor-bot tor-bot merged commit ee860b8 into torproject:maint-0.3.3 Jun 14, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment