Split or h #151

nmathewson · 2018-06-15T19:48:59Z

No description provided.

This one was actually fairly simple.

For once, it's a type that is used almost nowhere else besides the logical place.

Now the entire connection_t hierarchy is extracted from or.h

More modules use this than I had expected!

This type is only used in one place and never exposed.

I was expecting this to be much worse.

Since packed_cell and destroy_cell exist only to be queued, they go in the same headers as the queues.

coveralls · 2018-06-15T20:14:15Z

Coverage increased (+0.01%) to 59.868% when pulling 3edc48c on nmathewson:split_or_h into 945d871 on torproject:master.

nmathewson added 30 commits Jun 14, 2018

Move entry_port_cfg_t into its own header.

6896ab2

Make server_port_cfg_t and port_cfg_t into separate headers.

df9a3fe

Move dir_server_t into its own header.

2a574d1

Split entry and edge_connection_t into their own headers.

5d5c442

Split control_connection_t into its own header.

3b917b2

This one was actually fairly simple.

Split dir_connection_t into its own header

1416f54

Split listener_connection_t into its own header

6c0fe9d

For once, it's a type that is used almost nowhere else besides the logical place.

Move or_connection_t to its own header.

19c34b4

Split or_handshake_{certs,state}_t into their own headers.

bcc283b

Extract connection_t into its own header.

bba998a

Now the entire connection_t hierarchy is extracted from or.h

Extract {or,origin}_circuit_t into their own headers

a0bc164

Extract circuit_t into its own header

e0830ff

Extract crypt_path_t and relay_crypto_t into their own headers

b3f2c68

Extract crypt_path_reference_t into its own header.

c846b0e

Extract cpath_build_state into its own header.

d51de77

More modules use this than I had expected!

Extract tor_version_t into its own header.

7d2d131

Extract rend_service_descriptor_t into its own header.

22e9c64

Extract rend_intro_point_t into its own header.

990184d

Split rend_authorized_client_t and encoded_.._t into their own headers

5cdc234

Move vote_schedule into its own header.

f8794b0

Move fp_pair_t declaration to fp_pair.h.

c9e4ebf

Move measured_bw_line_t into dirserv.h

e13f594

Move network_liveness_t into circuitstats.h and make it private

ad52fe7

This type is only used in one place and never exposed.

Split socks_request_t into its own header.

8b7df72

Extract node_t into its own header.

d2942d1

Split vote_{microdesc_hash,routerstatus}_t into their own headers

72d2fd8

fixup! Extract node_t into its own header.

f901ca9

Move document_signature_t into its own header.

80c9e1e

Extract networkstatus_vote_info_t into its own header.

89aefb0

Extract networkstatus_t and ..sr_info_t into their own headers

50369f8

nmathewson added 14 commits Jun 15, 2018

Extract ns_detached_signatures_st into its own header.

62315da

Extract desc_store_t and routerlist_t into their own headers.

b8ae411

Extract authority_cert_t into its own header

1e4e9db

Extract extrainfo_t into its own header

00f1d16

Extract routerstatus_t into its own header.

def1f20

Extract microdesc_t into its own header.

9d6276b

Extract routerinfo_t into its own header.

ed0731c

I was expecting this to be much worse.

Extract signed_descriptor_t into its own header.

03fc83a

Extract download_status_t into its own header.

f85d731

Extract cached_dir_t into a new header.

958df28

Extract cell type and their queues into new headers

fde868f

Since packed_cell and destroy_cell exist only to be queued, they go in the same headers as the queues.

Move extend_info_t into its own header.

3191ba3

Move hsdir_index_t into its own header.

7dbe504

Add a changes file for splitting structures out of or.h

3edc48c

tor-bot merged commit 3edc48c into torproject:master Jun 18, 2018
2 of 3 checks passed

torproject / tor Public

Split or h #151

Split or h #151

nmathewson commented Jun 15, 2018

coveralls commented Jun 15, 2018

torproject / tor Public

Split or h #151

Split or h #151

Conversation

nmathewson commented Jun 15, 2018

coveralls commented Jun 15, 2018