Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32415 #1517

Merged
merged 8 commits into from Nov 18, 2019
Merged

Ticket32415 #1517

merged 8 commits into from Nov 18, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Nov 7, 2019

No description provided.

nmathewson added 4 commits Nov 7, 2019
@nmathewson
Make all our struct names end with "_t".
4845ab5 
This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        address_ttl_s address_ttl_t \
        aes_cnt_cipher aes_cnt_cipher_t \
        authchallenge_data_s authchallenge_data_t \
        authenticate_data_s authenticate_data_t \
        cached_bw_event_s cached_bw_event_t \
        cbuf cbuf_t \
        cell_ewma_s cell_ewma_t \
        certs_data_s certs_data_t \
        channel_idmap_entry_s channel_idmap_entry_t \
        channel_listener_s channel_listener_t \
        channel_s channel_t \
        channel_tls_s channel_tls_t \
        circuit_build_times_s circuit_build_times_t \
        circuit_muxinfo_s circuit_muxinfo_t \
        circuitmux_policy_circ_data_s circuitmux_policy_circ_data_t \
        circuitmux_policy_data_s circuitmux_policy_data_t \
        circuitmux_policy_s circuitmux_policy_t \
        circuitmux_s circuitmux_t \
        coord coord_t \
        cpuworker_job_u cpuworker_job_u_t \
        cv_testinfo_s cv_testinfo_t \
        ddmap_entry_s ddmap_entry_t \
        dircollator_s dircollator_t \
        dist_ops dist_ops_t \
        ecdh_work_s ecdh_work_t \
        ewma_policy_circ_data_s ewma_policy_circ_data_t \
        ewma_policy_data_s ewma_policy_data_t \
        fp_pair_map_entry_s fp_pair_map_entry_t \
        fp_pair_map_s fp_pair_map_t \
        guard_selection_s guard_selection_t \
        mbw_cache_entry_s mbw_cache_entry_t \
        outbuf_table_ent_s outbuf_table_ent_t \
        queued_event_s queued_event_t \
        replyqueue_s replyqueue_t \
        rsa_work_s rsa_work_t \
        sandbox_cfg_elem sandbox_cfg_elem_t \
        scheduler_s scheduler_t \
        smp_param smp_param_t \
        socket_table_ent_s socket_table_ent_t \
        state_s state_t \
        threadpool_s threadpool_t \
        timeout_cb timeout_cb_t \
        tor_libevent_cfg tor_libevent_cfg_t \
        tor_threadlocal_s tor_threadlocal_t \
        url_table_ent_s url_table_ent_t \
        worker_state_s worker_state_t \
        workerthread_s workerthread_t \
        workqueue_entry_s workqueue_entry_t
@nmathewson
ntmain: make service_fns struct anonymous.
0644530
@nmathewson
Rename probability distribution names to end with "_t".
31a6a65 
I needed to do this by hand, since we also use these for function
names, variable names, macro expansion, and a little token pasting.
@nmathewson
Changes file for 32415 (struct name uniformity)
c9b2fe0
@coveralls
Copy link

@coveralls coveralls commented Nov 7, 2019 •
edited

Pull Request Test Coverage Report for Build 7265

  • 78 of 90 (86.67%) changed or added relevant lines in 10 files are covered.
  • 1167 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.06%) to 62.426%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/channel.c 5 6 83.33%
src/feature/control/control_events.c 0 1 0.0%
src/feature/dircache/consdiffmgr.c 0 1 0.0%
src/lib/math/prob_distr.c 57 66 86.36%
Files with Coverage Reduction New Missed Lines %
src/lib/confmgt/type_defs.c 1 99.5%
src/core/mainloop/netstatus.c 3 92.0%
src/lib/confmgt/unitparse.c 3 94.34%
src/lib/confmgt/confmgt.c 4 99.14%
src/lib/crypt_ops/crypto_openssl_mgt.c 6 78.38%
src/lib/intmath/muldiv.c 6 0.0%
src/lib/crypt_ops/crypto_init.c 8 86.49%
src/app/main/subsysmgr.c 24 85.8%
src/feature/dirauth/shared_random_state.c 37 89.13%
src/app/config/statefile.c 80 52.31%
Totals Coverage Status
Change from base Build 7135: 0.06%
Covered Lines: 48723
Relevant Lines: 78049
💛 - Coveralls

nmathewson added 4 commits Nov 16, 2019
@nmathewson
Revise struct names in examples in comments to end with _t
5a1a60e
@nmathewson
handles.h: replace structname with structname_t
0c80c2e 
This change makes our macro bodies consistent with our naming
expectations for structs and types outside macro bodies.
@nmathewson
map.h: replace maptype with mapname_t
cc271af 
This change makes our macro bodies consistent with our naming
expectations for structs and types outside macro bodies.
@nmathewson
Make structs declared by tor_queues.h macros also follow naming rules
59ba61a
@torproject-pusher torproject-pusher merged commit 59ba61a into torproject:master Nov 18, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment