Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32404 #1518

Merged
merged 2 commits into from Nov 11, 2019
Merged

Ticket32404 #1518

merged 2 commits into from Nov 11, 2019

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @teor2345 @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Nov 7, 2019

No description provided.

@nmathewson
New configuration flag to warn that a variable is obsolete.
36af84b 
Part of 32404.
@coveralls
Copy link

@coveralls coveralls commented Nov 7, 2019 •
edited

Pull Request Test Coverage Report for Build 7139

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.0008%) to 62.424%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
Totals Coverage Status
Change from base Build 7137: -0.0008%
Covered Lines: 48711
Relevant Lines: 78032
💛 - Coveralls

@nmathewson
Refactor "OBSOLETE" type
a08969e 
It no longer warns, and is now defined in terms of an "IGNORE" type.

(The "IGNORE" type is the same as "OBSOLETE", except that it is not
reported as obsolete. It should be useful for disabled modules.)

Closes ticket 32404.
teor2345
teor2345 reviewed Nov 11, 2019
View changes
src/lib/conf/conftypes.h
@@ -64,7 +64,8 @@ typedef enum config_type_t {
CONFIG_TYPE_LINELIST_V, /**< Catch-all "virtual" option to summarize
* context-sensitive config lines when fetching.
*/
CONFIG_TYPE_OBSOLETE, /**< Obsolete (ignored) option. */
CONFIG_TYPE_OBSOLETE, /**< Ignored (obsolete) option. Uses no storage. */
Copy link
Contributor

@teor2345 teor2345 Nov 11, 2019

Please explain the difference between OBSOLETE and IGNORE: I think the difference is that OBSOLETE warns, and IGNORE does not.

Also, I don't think any options are IGNORE right now? They are all OBSOLETE?

@torproject-pusher torproject-pusher merged commit a08969e into torproject:master Nov 11, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment