Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32451 #1531

Merged
merged 15 commits into from Nov 14, 2019
Merged

Ticket32451 #1531

merged 15 commits into from Nov 14, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 12, 2019

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Nov 12, 2019 •
edited

Pull Request Test Coverage Report for Build 7217

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 62.444%
Files with Coverage Reduction New Missed Lines %
src/app/config/config.c 4 78.8%
Totals Coverage Status
Change from base Build 7212: 0.01%
Covered Lines: 48737
Relevant Lines: 78049
💛 - Coveralls

teor2345 added 14 commits Nov 14, 2019
@teor2345
test/parseconf: Split the file list into sections
735d5f5 
There are lots of different files now, so having Config and Result
sections is helpful.

Part of 32451.
@teor2345
test/parseconf: Rewrite the included files section
4cf5d4c 
Part of 32451.
@teor2345
test/parseconf: Add an expected_log file
3df6432 
The "expected_log" file is a set of patterns that matches the
output of "tor --verify-config". Unlike "error", it expects a
successful exit status.

Part of 32451.
@teor2345
test/parseconf: Standardise output messages
7ef4410 
Part of 32451.
@teor2345
test/parseconf: Stop ignoring --dump-config failures
4514bfe 
When we added the $FILTER for Windows newlines, we made
the pipeline always exit successfully, even if tor failed.

Fixes bug 32468; bugfix on 0.4.2.1-alpha.
@teor2345
test/parseconf: Use consistent formatting
e6ca32f 
Make spacing, quotes, and env vars consistent.

Cleanup after 32451 and 32468.
@teor2345
test/parseconf: Rename some functions, and reformat
b4b3060 
Part of 32451.
@teor2345
test/parseconf: Refactor and standardise, stage 1
3904601 
Remove duplicate code, and standardise similar behaviour.
Add some additional error checking.

Cleanup after 32451.
@teor2345
test/parseconf: Refactor and simplify, stage 2
a5628cf 
Remove more duplicate code.
Eliminate some arguments.
Rewrite some comments.

Cleanup after 32451.
@teor2345
test/parseconf: Show tor command lines on failure
2c4ada7 
Part of 32451.
@teor2345
test/parseconf: Stop adding newlines to *_printf
51a6c0c 
Cleanup after 32451.
@teor2345
test/parseconf: Add failure cases in conf_failures/
c7838c7 
These failure cases can be used to test the failure behaviour
and failure logs of test_parseconf.sh.

See the README for details.

Part of 32451.
@teor2345
test/parseconf: Update conf_examples to use expected_log
ced434c 
Part of 32451.
@teor2345
test/parseconf: Warn when the expected_log* file is missing
aa3e2bb 
Part of 32451.
@teor2345
changes: file for 32451
9f37c0f
@torproject-pusher torproject-pusher merged commit 9f37c0f into torproject:master Nov 14, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment