Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26196 rebased #154

Closed
wants to merge 4 commits into from
Closed

#26196 rebased #154

wants to merge 4 commits into from

Conversation

Reviewers

@isislovecruft isislovecruft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rl1987 @coveralls @isislovecruft
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Jun 18, 2018

https://trac.torproject.org/projects/tor/ticket/26196
rl1987 added 4 commits Jun 18, 2018
@rl1987
Refrain from accessing empty smartlist in test_bridges_clear_bridge_list
b2d524c 
Just check that smartlist length is zero instead
@rl1987
Enable DEBUG_SMARTLIST in unit tests
dc061ea
@rl1987
Enable DEBUG_SMARTLIST for entire codebase when expensive hardening i…
7eb56d1 
…s on
@rl1987
Add changes file
d0c9277
@coveralls
Copy link

@coveralls coveralls commented Jun 18, 2018

Coverage Status

Coverage decreased (-0.003%) to 59.871% when pulling d0c9277 on rl1987:bug26196_rebased into 3640c63 on torproject:master.

@isislovecruft isislovecruft self-requested a review Jun 18, 2018
isislovecruft
isislovecruft approved these changes Jun 18, 2018
View changes
Copy link
Contributor

@isislovecruft isislovecruft left a comment

LGTM! Thanks!

@rl1987 rl1987 closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment