Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32500 035 #1540

Closed
wants to merge 4 commits into from
Closed

Ticket32500 035 #1540

wants to merge 4 commits into from

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @tlyu
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 15, 2019

No description provided.

@teor2345
Travis: use -std=gnu99 when compiling
4276384 
Require C99 standards-conforming code in Travis CI, but allow GNU gcc
extensions. Also activates clang's -Wtypedef-redefinition warnings.

Closes ticket 32500.
@coveralls
Copy link

@coveralls coveralls commented Nov 15, 2019 •
edited

Pull Request Test Coverage Report for Build 7353

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1240 unchanged lines in 34 files lost coverage.
  • Overall coverage decreased (-1.7%) to 59.083%
Files with Coverage Reduction New Missed Lines %
src/feature/dirclient/dirclient.c 1 18.5%
src/feature/hs/hs_common.c 1 82.3%
src/feature/hs/hs_service.c 1 73.37%
src/feature/nodelist/nodelist.c 1 61.26%
src/core/or/circuitlist.c 2 55.45%
src/core/or/policies.c 2 84.6%
src/feature/dircache/consdiffmgr.c 2 90.06%
src/feature/nodelist/microdesc.c 2 73.12%
src/feature/relay/router.c 2 35.02%
src/feature/rend/rendcache.c 2 92.89%
Totals Coverage Status
Change from base Build 7309: -1.7%
Covered Lines: 43158
Relevant Lines: 73047
💛 - Coveralls

tlyu
tlyu approved these changes Nov 15, 2019
View changes
@teor2345 teor2345 force-pushed the ticket32500_035 branch from 94f7d38 to 9b2a18a Nov 16, 2019
@teor2345 teor2345 mentioned this pull request Nov 16, 2019
Closed
@teor2345 teor2345 mentioned this pull request Nov 16, 2019
Closed
teor2345 added 2 commits Nov 27, 2019
@teor2345
Travis: use -std=gnu99 in some jobs
80a5af2 
Require C99 standards-conforming code in Travis CI, but allow GNU gcc
extensions. Also activates clang's -Wtypedef-redefinition warnings.

Build some jobs with -std=gnu99, and some jobs without.

Closes ticket 32500.
@teor2345
Merge branch 'ticket32500_029' into ticket32500_035
46596c0 
Merge C_DIALECT_OPTIONS from ticket32500_029 with
other configure options from maint-0.3.5.
@teor2345 teor2345 force-pushed the ticket32500_035 branch from 9b2a18a to 46596c0 Nov 27, 2019
@teor2345
Travis: use -std=gnu99 with NSS, and clang with Chutney
a26abf8 
NSS:
* test NSS-specific code with -std=gnu99
* use a recent gcc version from the latest Ubuntu image

Chutney:
* use clang, so we keep one clang Linux job
* keep clang on a fast job, so the overall build finishes quickly

Closes ticket 32500 for 0.3.5.
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Dec 3, 2019

Squashed and merged.

@teor2345 teor2345 closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment