Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket 20218: refactor routerstatus_has_changed #1549

Closed
wants to merge 9 commits into from
Closed

Ticket 20218: refactor routerstatus_has_changed #1549

wants to merge 9 commits into from

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vnepveu @coveralls @teor2345
@vnepveu
Copy link
Contributor

@vnepveu vnepveu commented Nov 17, 2019

  • Check all the fields in the function routerstatus_has_changed
vnepveu added 2 commits Nov 12, 2019
@vnepveu
Refactor routerstatus_has_changed function
b2fe785 
- Check all fields that might change in a routerstatus
- Document the refactoring

Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
@vnepveu
Merge branch 'vnepveu' of github.com:vnepveu/tor
7cb494f
@coveralls
Copy link

@coveralls coveralls commented Nov 17, 2019 •
edited

Pull Request Test Coverage Report for Build 7604

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 693 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/networkstatus.c 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/encoding/kvline.c 1 98.95%
src/feature/control/control_proto.c 23 81.07%
src/feature/control/control_getinfo.c 181 30.67%
src/feature/control/control_cmd.c 488 18.18%
Totals Coverage Status
Change from base Build 7534: 0.04%
Covered Lines: 49570
Relevant Lines: 78649
💛 - Coveralls

@vnepveu vnepveu changed the title Refactoring: refactor routerstatus_has_changed Ticket 20218: refactor routerstatus_has_changed Nov 21, 2019
vnepveu added 2 commits Nov 24, 2019
@vnepveu
Merge branch 'master' of https://git.torproject.org/tor into ticket20218
bed9c61
@vnepveu
Rewrite change file to comply with tests
7e360a1 
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
teor2345
teor2345 suggested changes Nov 25, 2019
View changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Just a few minor comment and field changes needed.

src/feature/nodelist/networkstatus.c Outdated Show resolved Hide resolved
src/feature/nodelist/networkstatus.c Show resolved Hide resolved
src/feature/nodelist/networkstatus.c Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Nov 25, 2019
View changes
changes/ticket20218 Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Nov 25, 2019
View changes
changes/ticket20218 Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Nov 25, 2019
View changes
changes/ticket20218 Outdated Show resolved Hide resolved
vnepveu added 4 commits Dec 11, 2019
@vnepveu
Merge branch 'master' of https://git.torproject.org/tor into ticket20218
589dc7a
@vnepveu
Add comments
b4205ca 
- All three code locations interacting with
  routerstatus_has_changed function should be
  kept in sync

Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
@vnepveu
Add flag checks in routerstatus_has_changed
135e1a9 
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
@vnepveu
Rectify bugfix version in change file
9e156ed 
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
@vnepveu vnepveu closed this Dec 12, 2019
@vnepveu vnepveu reopened this Dec 12, 2019
teor2345
teor2345 reviewed Dec 19, 2019
View changes
changes/ticket20218 Outdated Show resolved Hide resolved
@vnepveu @teor2345
Update changes/ticket20218
7efa400 
Co-Authored-By: teor <teor@torproject.org>
@vnepveu
Copy link
Contributor Author

@vnepveu vnepveu commented May 5, 2020

Closing because it was merged in #1673

@vnepveu vnepveu closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment