New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 20218: refactor routerstatus_has_changed #1549
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iqdecay
commented
Nov 17, 2019
- Check all the fields in the function routerstatus_has_changed
- Check all fields that might change in a routerstatus - Document the refactoring Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
Pull Request Test Coverage Report for Build 7604
💛 - Coveralls |
iqdecay
changed the title
Refactoring: refactor routerstatus_has_changed
Ticket 20218: refactor routerstatus_has_changed
Nov 21, 2019
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
teor2345
suggested changes
Nov 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comment and field changes needed.
teor2345
reviewed
Nov 25, 2019
teor2345
reviewed
Nov 25, 2019
teor2345
reviewed
Nov 25, 2019
- All three code locations interacting with routerstatus_has_changed function should be kept in sync Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
teor2345
reviewed
Dec 19, 2019
Co-Authored-By: teor <teor@torproject.org>
Closing because it was merged in #1673 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.