Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 20218: refactor routerstatus_has_changed #1549

Closed
wants to merge 9 commits into from

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Nov 17, 2019

  • Check all the fields in the function routerstatus_has_changed

- Check all fields that might change in a routerstatus
- Document the refactoring

Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
@coveralls
Copy link

coveralls commented Nov 17, 2019

Pull Request Test Coverage Report for Build 7604

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 693 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.027%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/nodelist/networkstatus.c 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/encoding/kvline.c 1 98.95%
src/feature/control/control_proto.c 23 81.07%
src/feature/control/control_getinfo.c 181 30.67%
src/feature/control/control_cmd.c 488 18.18%
Totals Coverage Status
Change from base Build 7534: 0.04%
Covered Lines: 49570
Relevant Lines: 78649

💛 - Coveralls

@iqdecay iqdecay changed the title Refactoring: refactor routerstatus_has_changed Ticket 20218: refactor routerstatus_has_changed Nov 21, 2019
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comment and field changes needed.

src/feature/nodelist/networkstatus.c Outdated Show resolved Hide resolved
src/feature/nodelist/networkstatus.c Show resolved Hide resolved
src/feature/nodelist/networkstatus.c Outdated Show resolved Hide resolved
changes/ticket20218 Outdated Show resolved Hide resolved
changes/ticket20218 Outdated Show resolved Hide resolved
changes/ticket20218 Outdated Show resolved Hide resolved
- All three code locations interacting with
  routerstatus_has_changed function should be
  kept in sync

Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
Signed-off-by: vnepveu <victor.nepveu@imt-atlantique.net>
@iqdecay iqdecay closed this Dec 12, 2019
@iqdecay iqdecay reopened this Dec 12, 2019
changes/ticket20218 Outdated Show resolved Hide resolved
Co-Authored-By: teor <teor@torproject.org>
@iqdecay
Copy link
Contributor Author

iqdecay commented May 5, 2020

Closing because it was merged in #1673

@iqdecay iqdecay closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants