Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32613 #1569

Closed
wants to merge 6 commits into from
Closed

Ticket32613 #1569

wants to merge 6 commits into from

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @teor2345
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Nov 26, 2019

No description provided.

nmathewson added 2 commits Nov 26, 2019
@nmathewson
checkSpace.pl: make output more uniform.
2aaa7ae 
There were lots of slight differences in indentation and formatting
among the in-file error messages.
@nmathewson
Add a simple test for checkSpace.pl
eb271ef 
This script is not expected to work on windows due to line-ending
issues, so I'm not making it get run on an automated basis.  We
should use it when editing checkSpace.pl.

Closes ticket 32613.
@coveralls
Copy link

@coveralls coveralls commented Nov 26, 2019 •
edited

Pull Request Test Coverage Report for Build 7374

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1352 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.95%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 4 85.0%
src/feature/dirauth/dirvote.c 9 64.85%
src/feature/rend/rendclient.c 12 23.82%
src/core/or/circuitlist.c 61 58.93%
src/feature/hs/hs_client.c 85 52.68%
src/feature/hs/hs_service.c 142 73.36%
src/feature/hs/hs_circuit.c 169 42.52%
src/core/or/circuituse.c 209 31.56%
src/feature/control/control_events.c 248 39.14%
src/app/config/config.c 413 79.67%
Totals Coverage Status
Change from base Build 7329: 0.01%
Covered Lines: 49419
Relevant Lines: 78505
💛 - Coveralls

teor2345
teor2345 suggested changes Nov 27, 2019
View changes
Copy link
Contributor

@teor2345 teor2345 left a comment

There's a typo in a function name, everything else looks fine.

scripts/maint/checkspace_tests/dubious.c Outdated
}

void
unexcpected_space(void)
Copy link
Contributor

@teor2345 teor2345 Nov 27, 2019

Typo:

Suggested change
unexcpected_space(void)
unexpected_space(void)

nmathewson added 4 commits Dec 2, 2019
@nmathewson
fixup! Add a simple test for checkSpace.pl
21f9765 
Correct "expected" output.
@nmathewson
Have checkSpaceTest.sh exit as skipped when on Windows
8c9a766 
Managing line-ending issues for this one isn't worth it.
@nmathewson
Distribute checkSpaceTest.sh and run it when we have perl.
30daef9
@nmathewson
fixup! Add a simple test for checkSpace.pl
3d5d82e 
Rename a function in "dubious.c"
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 3, 2019

Squashed and merged.

@teor2345 teor2345 closed this Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment