Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32020 043 02 #1573

Merged
merged 8 commits into from Nov 27, 2019
Merged

Ticket32020 043 02 #1573

merged 8 commits into from Nov 27, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@asn-d6 @coveralls @torproject-pusher @dgoulet-tor
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Nov 27, 2019

No description provided.

dgoulet-tor added 8 commits Nov 20, 2019
@dgoulet-tor
circ: Add hidden service helper functions
5887947 
Functions to correctly identify HS circuit type and version.

Part of #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor
hs-v2: Move v2 circuit cleanup actions into hs_circ_cleanup()
00136c9 
Refactor to decomplexify circuit_about_to_free() and finally have one single
entry point into the HS subsystems (v2 and v3) for when a circuit is freed.

With this, hs_circ_cleanup() becomes the one and only entry point when a
circuit is freed which then routes to the right subsystem version for any
actions to be taken.

This moves a big chunk of code from circuituse.c to rendclient.c. No behavior
change. Next commit will refactor it to reduce our technical debt.

Part of #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
hs-v2: Modernize rend_client_circuit_cleanup() code
1aafe33 
Old and messy code path. Structure it in a more pleasant and readable way. No
behavior change with this refactor.

Part of #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
hs-v3: Note client intro circuit failure
7f83c43 
Report back to the v3 subsystem any introduction point client circuit failure
so they can be noted down in the failure cache.

Fixes #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
hs-v3: Give a cleanup type to hs_circ_cleanup()
cbc4954 
By centralizing the circuit cleanup type that is: on close, free and
repurpose, some actions on the circuit can not happen for a certain cleanup
type or for all types.

This passes a cleanup type so the HS subsystem (v2 and v3) can take actions
based on the type of cleanup.

For instance, there is slow code that we do not run on a circuit close but
rather only on free.

Part of #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
hs-v3: Remove unused hs_service_intro_circ_has_closed()
a423cec 
Since the removal of ip->circuit_established, this function does litterally
nothing so clean it up.

Part of #32020

Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
test: Add unit tests for closing intro circ on failure
c508513 
Signed-off-by: David Goulet <dgoulet@torproject.org>
@dgoulet-tor @asn-d6
hs: Add changes file for 32020
85b984d 
Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Nov 27, 2019

Pull Request Test Coverage Report for Build 7351

  • 73 of 88 (82.95%) changed or added relevant lines in 5 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 62.949%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuituse.c 16 17 94.12%
src/feature/hs/hs_circuit.c 18 20 90.0%
src/feature/rend/rendclient.c 12 24 50.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_circuit.c 2 42.52%
src/feature/dirauth/shared_random.c 4 85.0%
src/feature/dirauth/dirvote.c 9 64.85%
Totals Coverage Status
Change from base Build 7348: 0.01%
Covered Lines: 49424
Relevant Lines: 78514
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 85b984d into torproject:master Nov 27, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment