Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug31531 #1574

Merged
merged 5 commits into from Dec 1, 2019
Merged

Bug31531 #1574

merged 5 commits into from Dec 1, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @neelchauhan
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 29, 2019

No description provided.

neelchauhan and others added 5 commits Nov 27, 2019
@neelchauhan
Make control_event_conf_changed() take a config_line_t
99cf3f9
@teor2345
control: Remove an unnecessary header in control_events.h
7572988 
And replace it with a struct forward declaration.

Also, move all the headers in the file before the forward
declaration.

Cleanup after 31531.
@teor2345
control: Rename a function variable
7a69b3a 
Cleanup after 31531.
@teor2345
control: Remove an unused function return value
f8f278f 
Cleanup after 31531.
@teor2345
control: Update an outdated function comment
41a3930 
Cleanup after 31531.
@coveralls
Copy link

@coveralls coveralls commented Nov 29, 2019

Pull Request Test Coverage Report for Build 7355

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/control/control_events.c 2 6 33.33%
Totals Coverage Status
Change from base Build 7352: 0.02%
Covered Lines: 49432
Relevant Lines: 78505
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 41a3930 into torproject:master Dec 1, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment