Ticket32806 #1619
Merged
Ticket32806 #1619
Conversation
This commit moves VersioningAuthoritativeDirectory, RecommendedClientVersions, and RecommendedServerVersions.
Some of these helpers will be needed in multiple places in the unit tests, so we should move them now.
This needs to be a point so that the CONF_VAR() macro can work correctly.
Pull Request Test Coverage Report for Build 7608
|
teor2345
reviewed
Jan 17, 2020
| @@ -23,6 +23,10 @@ CONF_VAR(AuthDirGuardBWGuarantee, MEMUNIT, 0, "2 MB") | |||
| /** Boolean: are we on IPv6? */ | |||
| CONF_VAR(AuthDirHasIPv6Connectivity, BOOL, 0, "0") | |||
|
|
|||
| /** True iff we should list bad exits, * and vote for all other exits as | |||
Copy-paste error: there's a stray * in the middle of the line.
teor2345
reviewed
Jan 17, 2020
| @@ -415,6 +409,12 @@ dirauth_options_pre_normalize(void *arg, char **msg_out) | |||
| "AuthDirGuardBWGuarantee", msg_out) < 0) | |||
| return -1; | |||
|
|
|||
| if (options->MinUptimeHidServDirectoryV2 < 0) { | |||
This code is only run by the unit tests: config_parse_units() returned an unsigned 64-bit integer, and units_ok() checks that it's non-negative.
teor2345
reviewed
Jan 17, 2020
| @@ -443,6 +437,12 @@ dirauth_options_validate(const void *arg, char **msg) | |||
| t = format_recommended_version_list(options->RecommendedServerVersions, 1); | |||
| tor_free(t); | |||
|
|
|||
| if (options->TestingAuthDirTimeToLearnReachability < 0) { | |||
This code is only run by the unit tests, see my earlier comments about interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: