Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TestingEstimatedDescriptorPropagationTime as obsolete. #1620

Merged
merged 1 commit into from Jan 6, 2020

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Dec 19, 2019

We stopped looking at this option in 85cf6dc, back when we
implemented the minimal pieces of prop275. Since then, we've had
code to validate and adjust this option, and to give it a different
value in testing networks, but the option hasn't actually done
anything.

We can safely mark it as OBSOLETE, since doing so does not make any
old configuration get rejected.

Closes ticket 32807.

We stopped looking at this option in 85cf6dc, back when we
implemented the minimal pieces of prop275.  Since then, we've had
code to validate and adjust this option, and to give it a different
value in testing networks, but the option hasn't actually done
anything.

We can safely mark it as OBSOLETE, since doing so does not make any
old configuration get rejected.

Closes ticket 32807.
@coveralls
Copy link

@coveralls coveralls commented Dec 19, 2019

Pull Request Test Coverage Report for Build 7607

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 63.013%

Totals Coverage Status
Change from base Build 7605: -0.002%
Covered Lines: 49561
Relevant Lines: 78652

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 42e31b5 into torproject:master Jan 6, 2020
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment