Ticket32822 #1626
Closed
Ticket32822 #1626
Conversation
Pull Request Test Coverage Report for Build 7780
|
dgoulet-tor
reviewed
Jan 8, 2020
src/feature/relay/router.c
Outdated
| tor_addr_port_t *ipv6_ap_out) | ||
| { | ||
| if (BUG(!ipv6_ap_out)) | ||
| return; |
I would use tor_assert() here because this is a caller convention setup rather than external input we can't control.
Furthermore, tor will misbehave after this return by accessing stack junk :S.
src/feature/relay/router.c
Outdated
| "Unable to use configured IPv6 address \"%s\" in a " | ||
| "descriptor. Skipping it. " | ||
| "Try specifying a globally reachable address explicitly.", | ||
| tor_addr_to_str(addrbuf, addr, sizeof(addrbuf), 1)); |
To avoid that extra addrbuf[], you could use fmt_addrport(). No strong opinion there.
When IPv6 ORPorts are set to "auto", tor relays and bridges would advertise an incorrect port in their descriptor. This may be a low-severity memory safety issue, because the published port number may be derived from uninitialised or out-of-bounds memory reads. Fixes bug 32588; bugfix on 0.2.3.9-alpha.
Return early when there is no suitable IPv6 ORPort. Show the address and port on error, using a convenience function. Code simplification and refactoring. Cleanup after 32588.
Authorities currently add themselves to the trusted dir servers list, but if they have an IPv6 ORPort, they leave it out. This commit makes authorities add their own IPv6 ORPort to the trusted dir servers list. Closes ticket 32822.
These tests don't actually exercise the authority IPv6 ORPort self-add feature in 32822, but they do improve coverage of the related config code. Part of 32822.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: